Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(PA-6394) Stop using FFI threads and use ruby threads for the windows puppet daemon #9386

Merged
merged 2 commits into from
Jun 7, 2024

Conversation

tvpartytonight
Copy link
Contributor

No description provided.

@tvpartytonight tvpartytonight requested a review from a team as a code owner June 6, 2024 17:48
@tvpartytonight
Copy link
Contributor Author

This is based off of the change submitted in #9338 but modifies the change in the daemon.rb to not pass in the Service_Main as an argument but to just access it directly.

@joshcooper
Copy link
Contributor

jenkins please test this on windows2012r2-64a,windows10ent-32a

Copy link
Contributor

@joshcooper joshcooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, wanted to verify beaker tests pass on 32 and 64 bit windows

@joshcooper joshcooper merged commit 7927dcf into puppetlabs:main Jun 7, 2024
15 checks passed
@joshcooper joshcooper added the backport 7.x Generate a backport PR to 7.x label Jun 7, 2024
Copy link

github-actions bot commented Jun 7, 2024

Backport failed for 7.x, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git fetch origin 7.x
git worktree add -d .worktree/backport-9386-to-7.x origin/7.x
cd .worktree/backport-9386-to-7.x
git checkout -b backport-9386-to-7.x
ancref=$(git merge-base 0c28d4f6f5aec1d6fd8c460528381d4e6e678c20 d6386ac3698aa665bf6fcec1c158f7840ff6b8d1)
git cherry-pick -x $ancref..d6386ac3698aa665bf6fcec1c158f7840ff6b8d1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 7.x Generate a backport PR to 7.x bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants